Fix target entry in .gitignore#13817
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 29, 2024
Merged
Conversation
Collaborator
rustbot
added
the
S-waiting-on-review
weihanglo
approved these changes
Apr 28, 2024
weihanglo
reviewed
Apr 28, 2024
.gitignore
Outdated
| @@ -1,4 +1,4 @@ | |||
| target | |||
| /target | |||
| Cargo.lock | |||
Member
There was a problem hiding this comment.
Could you also add a / prefix to Cargo.lock? I believe it has the same issue. Thank you :)
$ fd -HI Cargo.lock
Cargo.lock
tests/testsuite/cargo_add/locked_unchanged/in/Cargo.lock
tests/testsuite/cargo_add/lockfile_updated/in/Cargo.lock
tests/testsuite/cargo_add/lockfile_updated/out/Cargo.lock
tests/testsuite/cargo_remove/gc_patch/out/Cargo.lock
tests/testsuite/cargo_remove/update_lock_file/in/Cargo.lock
tests/testsuite/cargo_remove/update_lock_file/out/Cargo.lock
Contributor
Author
There was a problem hiding this comment.
done!
I also added it to the src/* entries since they all seem to be referring to the root as well.
rukai
force-pushed
the
fix_target_gitignore
branch
from
1f071b5 to
433635b
Compare
weihanglo
approved these changes
Apr 29, 2024
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Feel like some ignore entries are no longer necessary, but anyway we can look at them later.
Thanks!
Member
|
@bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 1, 2024
Update cargo 15 commits in b60a1555155111e962018007a6d0ef85207db463..6087566b3fa73bfda29702632493e938b12d19e5 2024-04-26 16:37:29 +0000 to 2024-04-30 20:45:20 +0000 - fix(cargo-fix): dont fix into standard library (rust-lang/cargo#13792) - refactor: Move diagnostic printing to Shell (rust-lang/cargo#13813) - Populate git information when building Cargo from Rust's source tarball (rust-lang/cargo#13832) - docs: fix several typos found by `typos-cli` (rust-lang/cargo#13831) - fix(alias): Aliases without subcommands should not panic (rust-lang/cargo#13819) - fix(toml): Improve granularity of traces (rust-lang/cargo#13830) - fix(toml): Warn, rather than fail publish, if a target is excluded (rust-lang/cargo#13713) - test(cargo-lints): Add a test to ensure cap-lints works (rust-lang/cargo#13829) - fix(toml)!: Remove support for inheriting badges (rust-lang/cargo#13788) - chore(ci): Don't check `cargo` against beta channel (rust-lang/cargo#13827) - Fix target entry in .gitignore (rust-lang/cargo#13817) - Bump to 0.81.0; update changelog (rust-lang/cargo#13823) - Add failing test: artifact_dep_target_specified (rust-lang/cargo#13816) - fix(cargo-lints): Don't always inherit workspace lints (rust-lang/cargo#13812) - Update SleepTraker returns_in_order unit test (rust-lang/cargo#13811) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The directories at:
Are getting picked up by the
targetentry in .gitignore, causing git to ignore any extra files added to those directories.A minor issue I know, but I still think its worth fixing.
Alternative
An alternative solution would be to rename those directories which I'm more than happy to do.
But I think we are better off just changing .gitignore as that is more future proof.