Unused dependencies cleanup

src/cargo/util/lints.rs

@@ -144,7 +144,7 @@ impl From<TomlLintLevel> for LintLevel {
 /// [RFC #3491]: https://rust-lang.github.io/rfcs/3491-remove-implicit-features.html
 const IMPLICIT_FEATURES: Lint = Lint {
     name: "implicit_features",
-    desc: "warn about the use of unstable features",
+    desc: "implicit features for optional dependencies is deprecated and will be unavailable in the 2024 edition",
     groups: &[],
     default_level: LintLevel::Allow,
     edition_lint_opts: Some((Edition::Edition2024, LintLevel::Deny)),
@@ -192,7 +192,7 @@ pub fn check_implicit_features(
         }
         let level = lint_level.to_diagnostic_level();
         let manifest_path = rel_cwd_manifest_path(path, gctx);
-        let message = level.title("unused optional dependency").snippet(
+        let message = level.title(IMPLICIT_FEATURES.desc).snippet(
             Snippet::source(manifest.contents())
                 .origin(&manifest_path)
                 .annotation(

tests/testsuite/lints/implicit_features/edition_2021/mod.rs

@@ -1,7 +1,7 @@
 use cargo_test_support::prelude::*;
 use cargo_test_support::project;
 use cargo_test_support::registry::Package;
-use cargo_test_support::str;
+use cargo_test_support::{file, str};
 
 #[cargo_test]
 fn case() {
@@ -23,12 +23,10 @@ bar = { version = "0.1.0", optional = true }
         .build();
 
     snapbox::cmd::Command::cargo_ui()
-        .masquerade_as_nightly_cargo(&["always_nightly"])
         .current_dir(p.root())
         .arg("check")
-        .arg("--quiet")
         .assert()
         .success()
         .stdout_matches(str![""])
-        .stderr_matches(str![""]);
+        .stderr_matches(file!["stderr.term.svg"]);
 }

tests/testsuite/lints/implicit_features/edition_2021_warn/mod.rs

@@ -26,10 +26,10 @@ implicit-features = "warn"
         .build();
 
     snapbox::cmd::Command::cargo_ui()
-        .masquerade_as_nightly_cargo(&["always_nightly"])
+        .masquerade_as_nightly_cargo(&["cargo-lints"])
         .current_dir(p.root())
         .arg("check")
-        .arg("--quiet")
+        .arg("-Zcargo-lints")
         .assert()
         .success()
         .stdout_matches(str![""])

tests/testsuite/lints/implicit_features/edition_2024/mod.rs

@@ -29,7 +29,7 @@ baz = ["dep:baz"]
         .build();
 
     snapbox::cmd::Command::cargo_ui()
-        .masquerade_as_nightly_cargo(&["always_nightly"])
+        .masquerade_as_nightly_cargo(&["edition2024"])
         .current_dir(p.root())
         .arg("check")
         .assert()

tests/testsuite/lints/implicit_features/warn/mod.rs

@@ -27,10 +27,10 @@ implicit-features = "warn"
         .build();
 
     snapbox::cmd::Command::cargo_ui()
-        .masquerade_as_nightly_cargo(&["always_nightly"])
+        .masquerade_as_nightly_cargo(&["cargo-lints", "edition2024"])
         .current_dir(p.root())
         .arg("check")
-        .arg("--quiet")
+        .arg("-Zcargo-lints")
         .assert()
         .success()
         .stdout_matches(str![""])

tests/testsuite/lints_table.rs

@@ -874,7 +874,7 @@ fn cargo_lints_underscore_supported() {
         .masquerade_as_nightly_cargo(&["-Zcargo-lints"])
         .with_stderr(
             "\
-warning: unused optional dependency
+warning: implicit features for optional dependencies is deprecated and will be unavailable in the 2024 edition
   --> Cargo.toml:12:17
    |
 12 |                 bar = { version = \"0.1.0\", optional = true }