chore: tracing be compat with rustc_log#13239
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 2, 2024
Merged
Conversation
The current version of rustfix cannot be used in rust-lang/rust due to the dependency on `tracing`. `tracing-core` is currently locked to 0.1.30, which is too old for the version in the cargo repo (it looks like they are trying to avoid a known deadlock). See: https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/rustfix.20is.20incompatible.20with.20rust-lang.2Frust
Collaborator
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
epage
approved these changes
Jan 2, 2024
Contributor
epage
left a comment
epage
left a comment
There was a problem hiding this comment.
Thoughts on also holding back the version in Cargo.toml to keep the version we test and use in production the same as rustc?
Either way, feel free to r= me
Member
Author
|
I am not sure if the deadlock is universal or rustc specific. Let's merge this, and if it is too bad we can pin the version then. @bors r=epage |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
1 similar comment
Contributor
|
☀️ Test successful - checks-actions |
Contributor
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
bors
added a commit
that referenced
this pull request
Jan 2, 2024
[beta-1.76.0] chore: tracing be compat with rustc_log Beta backports: - <#13239> In order to make CI pass, the following PRs are also cherry-picked: -
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2024
Update cargo 10 commits in add15366eaf3f3eb84717d3b8b71902ca36a7c84..2ce45605d9db521b5fd6c1211ce8de6055fdb24e 2024-01-02 03:24:42 +0000 to 2024-01-04 18:04:13 +0000 - feat(embedded): Add prefix-char frontmatter syntax support (rust-lang/cargo#13247) - Update dependency handlebars to v5 for mdman. (rust-lang/cargo#13249) - Deprecate rustc plugin support in cargo (rust-lang/cargo#13248) - feat(embedded): Add multiple experimental manifest syntaxes (rust-lang/cargo#13241) - chore: update auto labels (rust-lang/cargo#13244) - test: support publish package with a `public` field. (rust-lang/cargo#13245) - `cargo fix`: Call rustc fewer times. (rust-lang/cargo#13243) - chore: tracing be compat with rustc_log (rust-lang/cargo#13239) - chore(deps): update compatible (rust-lang/cargo#13227) - Contrib: Fix team HackMD links (rust-lang/cargo#13237) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
The current version of rustfix cannot be used in rust-lang/rust due to the dependency on
tracing.tracing-coreis currently locked to 0.1.30, which is too old for the version in the cargo repo (it looks like they are trying to avoid a known deadlock).See: https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/rustfix.20is.20incompatible.20with.20rust-lang.2Frust
Additional information
I guess we need a beta-backport for this?