Skip to content

Conversation

@steveklabnik
Copy link
Contributor

/cc @rust-lang/core

@rust-highfive
Copy link

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against gh-pages. Please double check that you specified the right target!


```rust
struct Foo; // works
struct Bar { }; // error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: no terminating semicolon here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gah, i always mess this up

@alexcrichton
Copy link
Member

🚆

@steveklabnik
Copy link
Contributor Author

@alexcrichton @nikomatsakis r? I fixed almost everything, one question about how to properly summarize the time changes

@steveklabnik
Copy link
Contributor Author

:shipit:

@steveklabnik steveklabnik merged commit 916831c into rust-lang:gh-pages Apr 14, 2016
RFC 6890.
* Various improvements to `CString`, used for FFI.
* checked, saturated, and overflowing operations for various numeric types.
These aren’t counted in that ‘40’ number above, because there are a _lot_ of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t the number 20 rather than 40? Or is 40 including all the new numeric types methods?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was a typo. i've since fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants