Fixed dead link in posts/2023-08-29-committing-lockfiles.md#1172
Closed
EliasHolzmann wants to merge 1 commit into
Closed
Fixed dead link in posts/2023-08-29-committing-lockfiles.md#1172EliasHolzmann wants to merge 1 commit into
EliasHolzmann wants to merge 1 commit into
Conversation
Said blog post contains a link to the Cargo book. The heading that was being linked to was changed from "Multiple requirements" to "Multiple version requirements" (in [this commit][doc-change]), this change was not reflected in the blog post. I am not too sure whether the link has ever worked as the docs were changed on 2023-08-27 while the blog post was only written on 2023-08-29, but either way, this commit fixes the link. [doc-change]: rust-lang/cargo@01e1ff0?diff=unified&w=0#diff-d184a3240b09684abaca1a50dc8519dab2a9f5a17631180036f4b8090bb8a2d0L105
Member
|
This may also need to be fixed in cargo book by adding a redirection there |
weihanglo
added a commit
to weihanglo/cargo
that referenced
this pull request
Dec 2, 2023
Author
|
Thanks! With this being fixed on the Cargo book side, I don't think this PR is necessary anymore (admittedly, the link now goes to a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Said blog post contains a link to the Cargo book. The heading that was being linked to was changed from "Multiple requirements" to "Multiple version requirements" (in this commit), this change was not reflected in the blog post. I am not too sure whether the link has ever worked as the docs were changed on 2023-08-27 while the blog post was only written on 2023-08-29, but either way, this PR fixes the link.