Add More FusedIterator #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Iterator is fused if the underlying Iterator is fused. (UniqueBy, Unique, InterleaveShortest, Product, MergeBy, FilterOk, FilterMapOk, Positions, Update) Combinations is fused.
Mark FusedIterator to WhileSome, RcIter, PadUsing, TupleWindows, TupleCombinations, RepeatN, Powerset, CombinationsWithReplacement, WithPosition, KMergeBy
jswrenn
approved these changes
Jun 8, 2021
Member
jswrenn
left a comment
jswrenn
left a comment
There was a problem hiding this comment.
Thanks for this thorough examination of so many iterators!
bors r+
Member
|
let's try that again bors r+ |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These Iterator is fused if the underlying Iterator is fused.
FilterOkFilterMapOkInterleaveShortestKMergeByMergeByPadUsingPositionsProductRcIterTupleWindowsUniqueUniqueByUpdateWhileSomeThese is fused even though the underlying Iterator is not fused.
CombinationsCombinationsWithReplacementPowersetRepeatNWithPositionFusedIteratorcan be added to these structs.Related #55, #152, #531, #533
I separate the pull request with #548 because these Iterator are sure to be fused because it was documented, but I'm not 100% sure that the structs in this PR is actually fused. (Though I believe it is.)