-
Notifications
You must be signed in to change notification settings - Fork 176
fix bug on cmse::TestTarget::mpu_region #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This function should read `mrvalid` and `mregion` fields from test target result, instead of `srvalid` and `sregion`.
|
Can you point to the spec that says this is how it should be? |
|
@thejpster Thanks for noting! I found the official ARM documents here at: https://developer.arm.com/documentation/dui1095/a/The-Cortex-M23-Instruction-Set/Miscellaneous-instructions/TT--TTT--TTA--and-TTAT?lang=en
According to the documents, SREGION and SRVALID indicates the SAU region for this address; the MPU region is declared by MREGION and MRVALID. |
|
Seems legit! |
thejpster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
This function should read
mrvalidandmregionfields from test target result, instead ofsrvalidandsregion.