mysql_async, disable default features (#285)

[glueball]

Disable default features for mysql_async. Enable only the minimal feature, which is required by the mysql_crate.

Also, removed the dependency with the tokio feature. Doesn't seem to be needed, since tokio isn't mentioned at all in the refinery_core::drivers::mysql_async module.

I was not sure how to test this, I did this and everything works:

test --workspace -F mysql_async -- --test-threads=1

[glueball]

Also, I think you could enable "minimal" in regular mysql instead of the manual flate2 dependency.

Some other dependencies could have some features removed also. Most notably tokio, is really "full" needed by refinery? Enabling features in refinery prevents downstream users from disabling them.

[jxs]

Hi, and thanks for this! ❤️

Also, I think you could enable "minimal" in regular mysql instead of the manual flate2 dependency.

Some other dependencies could have some features removed also. Most notably tokio, is really "full" needed by refinery? >Enabling features in refinery prevents downstream users from disabling them.

Yeah, with time I have been made aware (and suffered because 😅 ) of that, do you wanna go ahead and do it on this PR? we can update the wording to reflect the changes, I can then release a tiny as this shouldn't be breaking.

[glueball]

Yeah I can add that to the pr!

[glueball]

However, maybe this can be considered breaking. Not sure what the actual policy for that is.

Some downstream projects might be using features enabled now by refinery that are not listed in their own Cargo.toml. The fix is trivial, and if using rust 1.72 even the compiler warns what features to enable; but technically can be considered breaking.

[glueball]

Used cargo hack to check all possible feature combinations

cargo hack check --feature-powerset --no-dev-deps --skip default --workspace

I also took the liberty to update siphasher to 1.0, as my IDE was giving me a warning. The hasher seems to be covered by migration divergence tests, so if CI turns green it should be safe.

[jxs]

However, maybe this can be considered breaking. Not sure what the actual policy for that is.

Some downstream projects might be using features enabled now by refinery that are not listed in their own Cargo.toml. The fix is trivial, and if using rust 1.72 even the compiler warns what features to enable; but technically can be considered breaking.

yeah thanks for mentioning, I can release a minor instead

I am not at home currently, will try to do that Tomorrow!

[jxs]

thinking more about it, I am willing to run that risk. I hope there are not a lot of users doing it, but misusing the feature set should not be considered a feature I'd say, therefore we won't be breaking anything.
released 0.8.11

[glueball]

Great, thanks!

As a refinery user, I'm really not concerned about this change as I do usually manage all the features of my dependencies (but the rest of the team always turns to me to fix it when something breaks :P).