Merged
Conversation
9d9c85e to
316c788
Compare
316c788 to
925979f
Compare
Be-ing
reviewed
Jan 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes
futures-litein favor ofasync-stdas we are already using it withashpd, fixes issues with theErrorenum and removes unnecessary dependencies.Improvements:
src/platforms/freedesktop.rs: Implemented timeout handling usingasync-stdin thedetectfunction to avoid latency issues.src/error.rs: UpdatedErrorenum and related implementations to support FreeBSD, DragonFly, NetBSD, and OpenBSD in addition to Linux.src/error.rs: Added a newTimeoutvariant to theErrorenum to handle timeout errors.Cargo.toml: Updated dependencies by removingfutures-liteandtokio, and addingasync-std.Fixes #17