fix: add missing libc++ defines for zig 0.15+ bindgen support#398
Merged
fix: add missing libc++ defines for zig 0.15+ bindgen support#398
Conversation
81be251 to
e48f97e
Compare
1828f61 to
07bce3e
Compare
Zig 0.15+ libc++ headers require additional defines that were missing from BINDGEN_EXTRA_CLANG_ARGS, causing strstream and other I/O headers to fail when parsed by bindgen's libclang. Add the following defines: - _LIBCPP_HAS_LOCALIZATION=1 - _LIBCPP_HAS_WIDE_CHARACTERS=1 - _LIBCPP_HAS_UNICODE=1 - _LIBCPP_HAS_THREADS=1 Amp-Thread-ID: https://ampcode.com/threads/T-019bff26-4ab1-712c-8cc2-72cd1d8ffd51 Co-authored-by: Amp <amp@ampcode.com>
07bce3e to
7d307e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zig 0.15+ libc++ headers require additional defines that were missing from BINDGEN_EXTRA_CLANG_ARGS, causing strstream and other I/O headers to fail when parsed by bindgen's libclang.
Add the following defines: