WIP: Verify removal of Index trait bound#482
Closed
tcharding wants to merge 2 commits intorust-bitcoin:masterfrom
Closed
WIP: Verify removal of Index trait bound#482tcharding wants to merge 2 commits intorust-bitcoin:masterfrom
tcharding wants to merge 2 commits intorust-bitcoin:masterfrom
Conversation
tcharding
force-pushed
the
dev-verfiy-rm-index
branch
4 times, most recently
from
e3dae78 to
4e24b73
Compare
Clippy default settings seemed to have changed introducing a few new warnings. warning: variable does not need to be mutable warning: deref on an immutable reference warning: returning the result of a `let` binding from a block Fix them all in a single patch because CI has to pass for each patch.
Verify we can still build after `bitcoin_hashes` removes the `Index` trait bound and replaces it for `AsRef`.
tcharding
force-pushed
the
dev-verfiy-rm-index
branch
from
4e24b73 to
5c56181
Compare
Member
Author
|
Closing as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a merge candidate. The point of this PR is to verify rust-bitcoin/bitcoin_hashes#168
Verify we can still build after
bitcoin_hashesremoves theIndextrait bound and replaces it for
AsRef.