Fix inconsistent naming in the dummy key hash structs#463
Merged
sanket1729 merged 2 commits intorust-bitcoin:masterfrom Sep 26, 2022
Merged
Fix inconsistent naming in the dummy key hash structs#463sanket1729 merged 2 commits intorust-bitcoin:masterfrom
sanket1729 merged 2 commits intorust-bitcoin:masterfrom
Conversation
Member
|
CI failure is a broken dependency, fixed in a commit of #461 |
Also derive `Default` for `DummyHash` and all of its hash types since they are all empty structs.
afilini
force-pushed
the
fix/inconsistent-dummy-hash-names
branch
from
eb2c282 to
af5d2d2
Compare
Contributor
Author
|
I cherry-picked Sanket's commit and rebased on top of it |
apoelstra
approved these changes
Sep 26, 2022
apoelstra
approved these changes
Sep 26, 2022
Member
|
FTR, we plan to remove the |
sanket1729
added a commit
to sanket1729/elements-miniscript
that referenced
this pull request
Oct 21, 2022
…022_10 b6daa97 Merge rust-bitcoin/rust-miniscript#463: Fix inconsistent naming in the dummy key hash structs Export structs from upstream instead
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…e dummy key hash structs
af5d2d24da840ea5a0753799e344e9a5a16e238d Fix inconsistent naming in the dummy key hash structs (Alekos Filini)
637f5cef74a0b1b338d53ec967e587728ecf55d5 MSRV fixes for once_cell (sanket1729)
Pull request description:
Also derive `Default` for `DummyHash` and all of its hash types since they are all empty structs.
ACKs for top commit:
apoelstra:
ACK af5d2d24da840ea5a0753799e344e9a5a16e238d
Tree-SHA512: 6ecee59932573fbfd2784bfabad0efbab1f9840f16cd4ab78c11c2ddcabab08307723c54c52a4bb4d00201ab91df9480185ace9da99f241fb986fc93cf07dfdd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also derive
DefaultforDummyHashand all of its hash types since they are all empty structs.