Update create_wallet to support Core v0.23.0

[evanlinjin]

If everything goes to plan, this Fixes #225

[dpc]

Just had a quick look and looks reasonable. 👍

[evanlinjin]

Just had a quick look and looks reasonable. 👍

Thank you for your review! It is not ready yet as tests are failing and not sure if changes are backwards compatible.

[dpc]

I don't know how is our mult-version support look like. In case there are any APIs that are slightly different:

• should we detect version automatically on start, or on first call that require it (and memoize), or have different API functions for different versions and let the user worry about calling the one that works?
• Do we construct enums for parts that are different, or just have different structs (that works with different functions)?

[dpc]

Do we need to extend the regtest suite to run with custom versions and then use docker-compose to run against each supported major version?

[evanlinjin]

I don't know how is our mult-version support look like. In case there are any APIs that are slightly different:

• should we detect version automatically on start, or on first call that require it (and memoize), or have different API functions for different versions and let the user worry about calling the one that works?
• Do we construct enums for parts that are different, or just have different structs (that works with different functions)?

These are some good points. I'll think over them.

[0xB10C]

Are you still working on this?

[stevenroose]

@everyone :) There is a merge request doing a total refactor of this crate that supports sync and async. I'm personally kinda hesitant to spend a lot of work reviewing changes before that gets in because it adds a rebase/maintenance burden on that big MR

#294