compilation fix for no-std#69
Merged
stevenroose merged 1 commit intorust-bitcoin:masterfrom Jun 12, 2025
Merged
Conversation
Merged
Contributor
Author
|
cc: @tcharding Would be nice to add this check to CI somehow. Do you have any idea how to do it? |
tcharding
reviewed
Apr 7, 2024
Co-authored-by: Tobin C. Harding <[email protected]>
9c3cee9 to
8653fb2
Compare
tcharding
approved these changes
Apr 8, 2024
|
Can you merge this? |
Member
Saw this comment because PR turned up in my notifications. Dunno if this is just as stale comment but there is a check for this in CI ATM on |
Member
cc @stevenroose |
|
@tcharding This PR is still valid Could you merge this and make a new release? |
Member
|
I am not a maintainer on this repo. |
Collaborator
|
Seems to not break anything for me and msrv, but I can't really test no_std locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes following compilation problem for no-std environments:
The problem can be reproduced with the following steps: