Skip to content

bitcoin_hashes >= 0.12, <= 0.13#60

Merged
stevenroose merged 1 commit intorust-bitcoin:masterfrom
kayabaNerve:master
Jan 29, 2024
Merged

bitcoin_hashes >= 0.12, <= 0.13#60
stevenroose merged 1 commit intorust-bitcoin:masterfrom
kayabaNerve:master

Conversation

@kayabaNerve
Copy link
Contributor

No description provided.

@kayabaNerve kayabaNerve mentioned this pull request Nov 28, 2023
@tcharding
Copy link
Member

tcharding commented Nov 28, 2023

Thanks for the contribution! I'm not the guy who merges things in this crate but if I was I'd want some sort of commit log and/or PR description for this. Its a breaking change and an unusual versioning style. ACK the changes though.

@kayabaNerve
Copy link
Contributor Author

It isn't a breaking change. bitcoin_hashes isn't exposed in any form AFAICT.

@tcharding
Copy link
Member

Oh no worries, my bad.

@kayabaNerve
Copy link
Contributor Author

@stevenroose Would you be willing to merge this and release 2.1.0? Is there some blocker I can work on?

@darosior
Copy link

darosior commented Jan 3, 2024

Just stumbled upon this. Bumping bitcoin_hashes in this crate would help me to avoid a duplicate bitcoin_hashes in liana's dependency:

$ cargo tree -d
bitcoin_hashes v0.11.0
└── bip39 v2.0.0
    └── liana v4.0.0 (/home/darosior/projects/wizardsardine/liana)

bitcoin_hashes v0.12.0
├── bitcoin v0.30.2
│   └── miniscript v10.0.0
│       └── liana v4.0.0 (/home/darosior/projects/wizardsardine/liana)
└── secp256k1 v0.27.0
    └── bitcoin v0.30.2 (*)

cc @stevenroose.

@stevenroose
Copy link
Collaborator

I prefer <0.14 over <=0.13, so that I'm sure we have bumpes to 0.13 included.

@stevenroose stevenroose merged commit 37915dc into rust-bitcoin:master Jan 29, 2024
@stevenroose
Copy link
Collaborator

I prefer <0.14 over <=0.13, so that I'm sure we have bumpes to 0.13 included.

Did this in 7f55439.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants