fix some important std unit tests that were not running due to typo#59
Closed
benma wants to merge 3 commits intorust-bitcoin:masterfrom
Closed
fix some important std unit tests that were not running due to typo#59benma wants to merge 3 commits intorust-bitcoin:masterfrom
benma wants to merge 3 commits intorust-bitcoin:masterfrom
Conversation
Member
|
Good catch! I've been bitten by that feature/features thing before. ACK 89385e6 |
Contributor
Author
|
Approve CI and merge? 😄 (edit: amended commit to add |
Not a lot of changes, and it is good to keep consistent with rustfmt as many editors and rust-analyzer automatically apply it.
`#[cfg(features = "std")]` is invalid and always disabled the whole block.
Member
|
Needs @stevenroose to kick CI, I don't have perms. |
tcharding
approved these changes
Nov 23, 2023
Collaborator
|
Merged the commit without the rustfmt stuff. Thanks, good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[cfg(features = "std")]is invalid and always disabled the whole block.rustfmt re-applied and explictly excluded the language slices - it seems the project generally uses rustfmt there is a .rustfmt.toml file).