Better expression support and general syntax cleanup#5
Closed
clarabstract wants to merge 2 commits intorussCloak:masterfrom
Closed
Better expression support and general syntax cleanup#5clarabstract wants to merge 2 commits intorussCloak:masterfrom
clarabstract wants to merge 2 commits intorussCloak:masterfrom
Conversation
... covers expressions inside argument defaults, also introduces some explicit knowledge of grouping literals
|
This is awesome! I hope it gets merged! |
Collaborator
|
Hi @rubyruy! I've merged your PR into my fork: https://github.com/petems/SublimePuppetSnippetsAndHighlights Since this one hasnt been updated in a while, I'm hoping to get mine added to the package manager 👍 |
Collaborator
|
Merged into master and released in https://github.com/russCloak/SublimePuppet/releases/tag/1.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers expressions inside argument defaults, adds function calls, various literals.
Basically just a number of fixes. There's more I could add based on this, like handling expressions inside string interpolation, covering hash/resource keys, resource references.
Not sure how alive this project is though...