Update to syntax definition to support resource names#25
Merged
petems merged 2 commits intorussCloak:masterfrom Feb 22, 2017
Merged
Update to syntax definition to support resource names#25petems merged 2 commits intorussCloak:masterfrom
petems merged 2 commits intorussCloak:masterfrom
Conversation
Previously resource names like sudo::conf would not be classified properly as source.puppet meta.definition.resource.puppet storage.type.puppet So things like cmd-r would break. This should fix that up without introducing anything else
Collaborator
|
@frizop Can you show a screenshot of the before and after? After that happy to merge 😃 |
Contributor
Author
|
I opened up the show scope name so you could see previously things were not named properly if they contained a ":" in the resource declaration |
Contributor
Author
|
Added in a second commit to fix the goto_symbol_in_project panel from being a little goofy looking. |
Collaborator
|
Looks good to me! 👍 |
frizop
pushed a commit
to frizop/SublimePuppet
that referenced
this pull request
May 12, 2017
Previously:
sqlserver::database { $dbname:
Wouldn't match because the \w+ character match misses ::
The other capture group for resource.puppet matches on variable named
resources, so I fixed that one in a previous commit, [PR russCloak#25]
frizop
pushed a commit
to frizop/SublimePuppet
that referenced
this pull request
May 14, 2017
This was originally fixed in [PR russCloak#25] but the second change here is for when the resource name is a variable (and it uses a different regex)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously resource names like sudo::conf would not be classified
properly as source.puppet meta.definition.resource.puppet storage.type.puppet
So things like cmd-r would break. This should fix that up without
introducing anything else