This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Implement APRProofViewer as an APRProof specific TUI #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwatson22
approved these changes
Jun 20, 2023
Comment on lines
+1
to
+61
| #navigation { | ||
| dock: left; | ||
| width: 35%; | ||
| height: 100%; | ||
| layout: vertical; | ||
| } | ||
| #behavior { | ||
| height: 1fr; | ||
| border: solid; | ||
| overflow-x: auto; | ||
| overflow-y: auto; | ||
| } | ||
|
|
||
| .cfg-node { | ||
| height: auto; | ||
| width: auto; | ||
| } | ||
|
|
||
| .hidden { | ||
| display: none; | ||
| } | ||
|
|
||
| #display { | ||
| layout: vertical; | ||
| } | ||
| #info-view { | ||
| height: 2fr; | ||
| border: solid; | ||
| overflow: auto scroll; | ||
| } | ||
| #term-view { | ||
| height: 15fr; | ||
| border: solid; | ||
| overflow: auto scroll; | ||
| } | ||
| #constraint-view { | ||
| height: 5fr; | ||
| border: solid; | ||
| overflow: auto scroll; | ||
| } | ||
| #custom-view { | ||
| height: 15fr; | ||
| border: solid; | ||
| overflow: auto scroll; | ||
| } | ||
| #info { | ||
| width: auto; | ||
| height: auto; | ||
| } | ||
| #term { | ||
| width: auto; | ||
| height: auto; | ||
| } | ||
| #constraint { | ||
| width: auto; | ||
| height: auto; | ||
| } | ||
| #custom { | ||
| width: auto; | ||
| height: auto; | ||
| } |
Contributor
There was a problem hiding this comment.
Is this just a clone of src/pyk/kcfg/style.css? I wonder if it would be better to have APRProofViewer inherit the styling from its superclass.
Member
Author
There was a problem hiding this comment.
Hmmmmm, that would be a good idea, sorry I didn't see this before it was merged.
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…tion/pyk#507) Following runtimeverification/pyk#489, it turns out that KEVM's TUI is broken because it relies on the old way of doing Node printing. This makes a new `APRProofViewer` class, which largely inherits from `KCFGViewer`, but adjusts it to handle the more spceific node viewers. I have tested this with both KEVM+Foundry and raw KEVM specs, and it seems to work. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
…tion/pyk#507) Following runtimeverification/pyk#489, it turns out that KEVM's TUI is broken because it relies on the old way of doing Node printing. This makes a new `APRProofViewer` class, which largely inherits from `KCFGViewer`, but adjusts it to handle the more spceific node viewers. I have tested this with both KEVM+Foundry and raw KEVM specs, and it seems to work. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
…tion/pyk#507) Following runtimeverification/pyk#489, it turns out that KEVM's TUI is broken because it relies on the old way of doing Node printing. This makes a new `APRProofViewer` class, which largely inherits from `KCFGViewer`, but adjusts it to handle the more spceific node viewers. I have tested this with both KEVM+Foundry and raw KEVM specs, and it seems to work. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
…tion/pyk#507) Following runtimeverification/pyk#489, it turns out that KEVM's TUI is broken because it relies on the old way of doing Node printing. This makes a new `APRProofViewer` class, which largely inherits from `KCFGViewer`, but adjusts it to handle the more spceific node viewers. I have tested this with both KEVM+Foundry and raw KEVM specs, and it seems to work. --------- Co-authored-by: devops <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #489, it turns out that KEVM's TUI is broken because it relies on the old way of doing Node printing.
This makes a new
APRProofViewerclass, which largely inherits fromKCFGViewer, but adjusts it to handle the more spceific node viewers.I have tested this with both KEVM+Foundry and raw KEVM specs, and it seems to work.