This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Remove manip.get_cell, add CTerm.free_vars #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
approved these changes
Mar 28, 2024
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
) Inspired while reviewing: runtimeverification/pyk#1009 This makes two changes which hopefully tighten the `CTerm` abstraction slightly by reducing the places where `CTerm.kast` is used: - Places that were doing `get_cell(CTerm.kast, CELL_NAME)` now say `CTerm.cell(CELL_NAME)`. There are no more uses of `get_cell` here or in downstream repos, so it's removed. - A new `@cached_property CTerm.free_vars` is added, which is used to replace the pattern `free_vars(CTerm.kast)`. This means that the remaining uses of `CTerm.kast` are doing something weird with the resulting kast, or printing it, or converting it to Kore. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
) Inspired while reviewing: runtimeverification/pyk#1009 This makes two changes which hopefully tighten the `CTerm` abstraction slightly by reducing the places where `CTerm.kast` is used: - Places that were doing `get_cell(CTerm.kast, CELL_NAME)` now say `CTerm.cell(CELL_NAME)`. There are no more uses of `get_cell` here or in downstream repos, so it's removed. - A new `@cached_property CTerm.free_vars` is added, which is used to replace the pattern `free_vars(CTerm.kast)`. This means that the remaining uses of `CTerm.kast` are doing something weird with the resulting kast, or printing it, or converting it to Kore. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
) Inspired while reviewing: runtimeverification/pyk#1009 This makes two changes which hopefully tighten the `CTerm` abstraction slightly by reducing the places where `CTerm.kast` is used: - Places that were doing `get_cell(CTerm.kast, CELL_NAME)` now say `CTerm.cell(CELL_NAME)`. There are no more uses of `get_cell` here or in downstream repos, so it's removed. - A new `@cached_property CTerm.free_vars` is added, which is used to replace the pattern `free_vars(CTerm.kast)`. This means that the remaining uses of `CTerm.kast` are doing something weird with the resulting kast, or printing it, or converting it to Kore. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
) Inspired while reviewing: runtimeverification/pyk#1009 This makes two changes which hopefully tighten the `CTerm` abstraction slightly by reducing the places where `CTerm.kast` is used: - Places that were doing `get_cell(CTerm.kast, CELL_NAME)` now say `CTerm.cell(CELL_NAME)`. There are no more uses of `get_cell` here or in downstream repos, so it's removed. - A new `@cached_property CTerm.free_vars` is added, which is used to replace the pattern `free_vars(CTerm.kast)`. This means that the remaining uses of `CTerm.kast` are doing something weird with the resulting kast, or printing it, or converting it to Kore. --------- Co-authored-by: devops <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired while reviewing: #1009
This makes two changes which hopefully tighten the
CTermabstraction slightly by reducing the places whereCTerm.kastis used:get_cell(CTerm.kast, CELL_NAME)now sayCTerm.cell(CELL_NAME). There are no more uses ofget_cellhere or in downstream repos, so it's removed.@cached_property CTerm.free_varsis added, which is used to replace the patternfree_vars(CTerm.kast).This means that the remaining uses of
CTerm.kastare doing something weird with the resulting kast, or printing it, or converting it to Kore.