Skip to content

Conversation

@Scott-Guest
Copy link
Contributor

Fixes #3439.

Whenever emitting attributes (to JSON, KORE, etc.), emit user-defined groups as [group(my-att-1, my-att-2)] even though the front-end internally represents them as [my-att-1, my-att-2].

This prevents user-defined groups from conflicting with internal attributes.

@Scott-Guest Scott-Guest self-assigned this May 30, 2023
@Scott-Guest
Copy link
Contributor Author

Scott-Guest commented May 31, 2023

Blocked on #2625

If there is some built-in attribute my-att unintentionally missing from the whitelist, then this change will cause it to be emitted to KORE as \group{}("my-att"), breaking anything downstream depending on my-att.

To be safe then, we should wait until the whitelist is complete and the option to opt-out is removed before merging this.

@Scott-Guest Scott-Guest linked an issue May 31, 2023 that may be closed by this pull request
@Scott-Guest Scott-Guest marked this pull request as ready for review July 3, 2023 19:09
@rv-jenkins rv-jenkins merged commit af33a0b into develop Jul 5, 2023
@rv-jenkins rv-jenkins deleted the group-internals branch July 5, 2023 11:42
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent internal attributes from leaking

4 participants