Update missing KLabel checks to stabilize error messages #3395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radumereuta
approved these changes
May 5, 2023
Baltoli
pushed a commit
that referenced
this pull request
Nov 1, 2023
…3085) * haskell-backend/src/main/native/haskell-backend: b88c128f3 - Transfer not simplified claims to applyClaim (#3398) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: 8352c471b - Remove `UnifierT` from `NotSimplifier` (#3404) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: 324773459 - Remove keys faster (#3395) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: 275afe775 - Monomorphization of Simplifier, leg 4 (#3408) * Sync flake inputs to submodules * haskell-backend/src/main/native/haskell-backend: 5a3472be3 - Update dependency: deps/k_release (#3406) * Sync flake inputs to submodules Co-authored-by: rv-jenkins <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #3390, I noticed that the missing KLabel error check in ModuleToKORE is done while iterating over a HashMap of attributes, which makes the order of errors unstable. This PR addresses that by sorting the attributes first.