kore-repl: debug-equation dynamically #1976
Conversation
andreiburdusa
left a comment
andreiburdusa
left a comment
There was a problem hiding this comment.
Looks good. I barely made a couple of observations. I can't find any place to refactor
| -> Log.KoreLogOptions | ||
| -> Log.KoreLogOptions | ||
| generalLogOptionsTransformer | ||
| logOptions@(GeneralLogOptions _ _ _ _) |
There was a problem hiding this comment.
Do you need to pattern match here?
There was a problem hiding this comment.
Yes, when a new field is added to GeneralLogOptions this will not type check anymore. This way we won't forget to modify this function as well.
| \debug-[type]-equation [eqId1] [eqId2] .. show debugging information for multiple specific equations;\ | ||
| \ [type] can be 'attempt' or 'apply', or nothing\ |
There was a problem hiding this comment.
I don't think anyone will get confused by this explanation, but when [type] is nothing then the remaining command is debug--equation (with two -)
There was a problem hiding this comment.
Yeah I wrote it like that initially, debug[-type]-equation, and thought it might actually be more confusing for a new user than the explanation above. If you think it's the other way around I can change it back.
There was a problem hiding this comment.
You're probably right
@andreiburdusa Maybe you could look through the |
Co-authored-by: Andrei Burdușa <[email protected]>
3 participants
Fixes #1956
Reviewer checklist
stack test --coveragestack haddock