Begin to plug the profiling gaps in the \ceil simplifier #1974
Conversation
ttuegel
changed the title
| import {-# SOURCE #-} qualified Kore.Step.Simplification.Ceil as Ceil | ||
| ( makeEvaluate | ||
| , makeEvaluateTerm | ||
| ( makeEvaluateTerm |
There was a problem hiding this comment.
Why is this still needed?
There was a problem hiding this comment.
It's not either, and if I also remove the import from Kore.Builtin.Builtin, then we can remove the .hs-boot file for Ceil! 🎉
| (ReaderT (SideCondition variable) simplifier) | ||
| (TermLike variable) | ||
| (OrCondition variable) | ||
| ceilSimplifierTermLike = |
There was a problem hiding this comment.
Where is this used, or where/why will this be needed?
There was a problem hiding this comment.
It's not, thanks for spotting that!
ana-pantilie
left a comment
ana-pantilie
left a comment
There was a problem hiding this comment.
Looks good! I couldn't find anything else to refactor, except removing some outdated comments. If you think there is anything else that could use some refactoring please let me know.
That sounds great! "Cleanup" might be better than "refactor" anyway. I think cleanup can include refactoring. |
3 participants
Fixes #1896
Reviewer checklist
stack test --coveragestack haddock