Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed:
MetricSummaryfields become dead stores after refactoring- Removed the unused Min, Max, Avg fields from MetricSummary struct and the dead calculateStats computation in GetMetricSummary since displayMetric recalculates stats from the Data slice.
- ✅ Fixed: Unused
calculateMinandcalculateMaxcontain new dead code- Removed the unused calculateMin and calculateMax functions which had no callers in the codebase.
…ateMax functions - Remove Min, Max, Avg fields from MetricSummary struct (never read, displayMetric recalculates stats from Data) - Remove dead calculateStats call and field assignments in GetMetricSummary - Remove unused calculateMin and calculateMax helper functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk because it upgrades the Go toolchain and multiple AWS SDK dependencies, and changes runtime handling of CloudWatch datapoints (filtering NaN/Inf) which could affect displayed stats/output.
Overview
Upgrades the project to Go 1.26 (including
mise.toml) and bumps AWS SDK v2,asciigraph, andgo-githubactionsdependencies.Hardens CloudWatch metric rendering by sanitizing float series across sparklines/charts and summary stats: NaN/Inf datapoints are filtered during fetch and before display/stats, with a new "(no valid data yet)" message when all values are invalid. Adds tests covering invalid-value filtering in
displayMetric.Written by Cursor Bugbot for commit f28251c. Configure here.