Use XDG runtime dir for UDS sockets#2195
Merged
sourishkrout merged 1 commit intorunmedev:mainfrom Oct 10, 2025
Merged
Conversation
Storing the socket in XDG_RUNTIME_DIR places it in the user-specific, permission-locked runtime directory instead of the shared /tmp directory. This is more secure and adheres to the freedesktop specification. Signed-off-by: Tom Wieczorek <tom@bibbu.net>
Contributor
|
One aspect, I will have to check is whether or not the Electron "sandbox" allows writes to these directories. When we first built the UDS vs TCP feature, I do remember we had trouble with writes being restricted. Turned out |
sourishkrout
approved these changes
Oct 10, 2025
Contributor
sourishkrout
left a comment
sourishkrout
left a comment
There was a problem hiding this comment.
Tested this on relevant platform, including WSL2. Works ✅.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing the socket in
XDG_RUNTIME_DIRplaces it in the user-specific, permission-locked runtime directory instead of the shared/tmpdirectory. This is more secure and adheres to the freedesktop specification.