fix(ci): build and push kwok-compute-domain-dra-plugin image (RUN-41041)#232
Open
eliranw wants to merge 1 commit into
Open
fix(ci): build and push kwok-compute-domain-dra-plugin image (RUN-41041)#232eliranw wants to merge 1 commit into
eliranw wants to merge 1 commit into
Conversation
The kwok-compute-domain-dra-plugin was a valid Dockerfile target, listed in the Makefile COMPONENTS and referenced by its Helm deployment, but was absent from the release-docker CI matrix. As a result the image was never pushed to ghcr, so enabling kwokComputeDomainDraPlugin.enabled failed with ImagePullBackOff. Add it to the matrix. Closes #228 Signed-off-by: Eliran Wolff <eliranw@nvidia.com>
iris-shain-runai
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
kwok-compute-domain-dra-pluginto therelease-dockerCI matrix so the image is actually built and pushed toghcr.io.Why
The component was a valid
Dockerfiletarget, listed inMakefileCOMPONENTS, and referenced by its Helm deployment — but missing from the hand-maintainedrelease-docker.strategy.matrix.componentlist in.github/workflows/ci.yml. So the image was never published, and enablingkwokComputeDomainDraPlugin.enabled: truefailed withImagePullBackOffonghcr.io/run-ai/fake-gpu-operator/kwok-compute-domain-dra-plugin:<tag>.Notes
status-exporter-kwokis also a Dockerfile target absent from the matrix, but it's intentionally not published: the kwok status-exporter deployment reuses thestatus-exporterimage (which packs both binaries), so no separate image is needed.Closes #228