Increase max_thunk_size from 1 MiB to 8 MiB#1583
Open
bamo wants to merge 1 commit into
Open
Conversation
Large C++ debug libraries on ARM64 (e.g. deal.II's libdeal_II.g.so) can have batches whose first-pass thunk group exceeds 4 MiB — mostly PLT- routed DSO imports — tripping the assertion at thunks.cc:217. 8 MiB is the smallest clean power-of-two cap above the empirical threshold (4 MiB fails, 5 MiB works). d_thunk_end already reserves max_thunk_size of space ahead of d, so a larger cap is safe by construction. No measurable wall-time or RSS impact in our testing. Fixes rui314#1538.
Contributor
Author
|
build failure is fixed by #1580 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large C++ debug libraries on ARM64 (e.g. deal.II's libdeal_II.g.so) can have batches whose first-pass thunk group exceeds 4 MiB — mostly PLT- routed DSO imports — tripping the assertion at thunks.cc:217. 8 MiB is the smallest clean power-of-two cap above the empirical threshold (4 MiB fails, 5 MiB works).
d_thunk_end already reserves max_thunk_size of space ahead of d, so a larger cap is safe by construction. No measurable wall-time or RSS impact in our testing.
Fixes #1538.