avm1: Remove is_slash_path argument in display_object::get_property
#22249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
added
A-avm1
moulins
force-pushed
the
avm1-no-is_slash_path
branch
2 times, most recently
from
0abdcbd to
65183b6
Compare
Lord-McSweeney
approved these changes
Nov 17, 2025
Having it set to `true` prevented the '_parent fallback' behavior in some cases where it shouldn't have (see added test), and it didn't have any other effect. Removing it also simplifies a lot of code, so this is a win/win!
moulins
force-pushed
the
avm1-no-is_slash_path
branch
from
65183b6 to
8d00ce4
Compare
Lord-McSweeney
removed
the
waiting-on-review
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Nov 23, 2025
-------------------------------------------------------------------------------------------------------- batocera-emulationstation.mk 0dcab740897e374bade0a365c238d7847259ed51 # Version: Commits on Nov 17, 2025 -------------------------------------------------------------------------------------------------------- Merge pull request #2012 from fabricecaruso/win [CarouselComponent] Fix potential crash when navigating back from a subfolder, ------------------------------------------------------------------------------------------------ batocera-es-piboy.mk 0dcab740897e374bade0a365c238d7847259ed51 # Version: Commits on Nov 17, 2025 ------------------------------------------------------------------------------------------------ Merge pull request #2012 from fabricecaruso/win [CarouselComponent] Fix potential crash when navigating back from a subfolder, --------------------------------------------------------------------------------------- amiberry.mk 27075b6197666c12e346e2679510a40ca04a1f9b # Version: Commits on Nov 18, 2025 --------------------------------------------------------------------------------------- enhancement: merge latest updates from WinUAE, ----------------------------------------------------------------------------------- cemu.mk f5b19278d1818845b3bf1653bce53d299c4eed5d # Version: Commits on Nov 18, 2025 ----------------------------------------------------------------------------------- UI: fix Curl deprecation warnings (#1724), ---------------------------------------------------------------------------------- clk.mk a9d945d6d25fb593f398a82e8ec911dbd372848b # Version: Commits on Nov 18, 2025 ---------------------------------------------------------------------------------- Merge pull request #1639 from TomHarte/CommodoreNew6502s Adapt all Commodore machines to 6502Mk2., ------------------------------------------------------------------------------------------ dolphin-emu.mk bd07d9dfd355764455e8128e5e7b6c53a61e4667 # Version: Commits on Nov 18, 2025 ------------------------------------------------------------------------------------------ Merge pull request #14136 from Simonx22/android/compress-callback-kotlin Android: Convert CompressCallback to Kotlin, ----------------------------------------------------------------------------------- eden.mk 0d3cef65adef4bc7b5c2dcd4120bfabc7da3d2cb # Version: Commits on Nov 18, 2025 ----------------------------------------------------------------------------------- fix clang-cl comp (#3044) -------------------------------------------------------------------------------------- flycast.mk 1dac3695fda391cfb4e03bd9f62c8018248b9365 # Version: Commits on Nov 18, 2025 -------------------------------------------------------------------------------------- imgui: ImguiStyleVar must be deleted before the end of the window, -------------------------------------------------------------------------------------- melonds.mk a34537392f5b13bf8114983228a76e565b073391 # Version: Commits on Nov 18, 2025 -------------------------------------------------------------------------------------- TSC: properly clamp output to 12 bits, -------------------------------------------------------------------------------------- openmsx.mk 572cbd0dccd1a3bb9300c692745440189778f3ec # Version: Commits on Nov 16, 2025 -------------------------------------------------------------------------------------- Auto size column widths, whilst still keeping them in sync. Patch created by Wouter. This makes the QSE look a bit more compact. As Wouter explained to me: We're currently using a \default table\ (I mean, without much configuration). But then you get a table where all the columns are the same width. And that leaves quite a bit of empty space between the two columns. Dear ImGui has an option to automatically determine the column width. That works, but it didn't look very nice because then the four tables wouldn't be properly aligned. I remembered that the standard Dear ImGui demo application has a solution for this. It demonstrates tables that are \in sync\: \Dear ImGui Demo > Tables & Columns > Synced Instances\ try resizing a column there; you'll see that the other tables stay in sync. The way to do that is apparently to give all the tables the same name. It seemed simple, but the TreeNode is the game-changer. Our tables are each under a different TreeNode. Because of that, the complete hierarchical name is different for our four tables. After some tinkering, I created a new utility function: \TreeNodeWithoutID().\ It works just like the regular \TreeNode()\ function, except that (conceptually) it doesn't add an extra ID to the ImGui ID stack. So, in terms of hierarchical name, the function is \transparent.\ And this one works. The \Quick Setup Editor\ window is now a bit more compact. This creates more usable space for long machine or media names., ---------------------------------------------------- pcsx2.mk v2.5.307 # Version: Commits on Nov 18, 2025 ---------------------------------------------------- - [OSD: More relevant save state timestamps](PCSX2/pcsx2#13524) -------------------------------------------------------------------------------------- tsugaru.mk 5488fd736573ce137d206fb3844396e53f5344e3 # Version: Commits on Nov 18, 2025 -------------------------------------------------------------------------------------- Looks like FBCNV.EXP changes the sector length to 256 to read from FM-77 disk. The DOS driver does not know that the sector length is changed to 256. Therefore, it tries to read from the disk once, and if no error, it assumes everything is ok. Unless lost data error is returned this time, the DOS driver does not re-examine the sector length, and the VM was crashing in the subsequent sector write., ------------------------------------------------- vice.mk r45857 # Version: Commits on Nov 18, 2025 ------------------------------------------------- use pango_cairo_font_map_set_default(NULL) after registering font, so that available fonts are rescanned. Windows needs to be tested. git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45857 379a1393-f5fb-40a0-bcee-ef074d9b53f7, ------------------------------------------------------------------------------------- vita3k.mk 5486a225f3a3323b1136e2b5a5eb4c6d1c420875 # Version: Commits on Nov 08, 2025 ------------------------------------------------------------------------------------- lang: Improve Polish localization, ----------------------------------------------------------------------------------- ymir.mk b1731764af3d7f552ace0c9aa9df2a868b983280 # Version: Commits on Nov 18, 2025 ----------------------------------------------------------------------------------- feat(savestates): Disallow selecting empty states from the Load State menu, ------------------------------------------------------------------------------------- ikemen.mk cb38ef65a2627a5f9b90020b1ee44a76e4444117 # Version: Commits on Nov 18, 2025 ------------------------------------------------------------------------------------- Merge pull request #2891 from rakieldev/fixes fix: backwards shadows/reflections xshear checks, --------------------------------------------------------------- ruffle.mk nightly-2025-11-18 # Version: Commits on Nov 18, 2025 --------------------------------------------------------------- ## What's Changed * build(deps-dev): bump js-yaml from 4.1.0 to 4.1.1 in /web by @dependabot[bot] in ruffle-rs/ruffle#22236 * build(deps): bump gif from 0.13.3 to 0.14.0 by @dependabot[bot] in ruffle-rs/ruffle#22272 * avm1: Remove `is_slash_path` argument in `display_object::get_property` by @moulins in ruffle-rs/ruffle#22249 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-11-17...nightly-2025-11-18, --------------------------------------------------------------------------------------- thextech.mk 93f6f090c62e5d94a69515d0941002ecd6fe3c06 # Version: Commits on Nov 18, 2025 --------------------------------------------------------------------------------------- gfx_camera.cpp: use integer offset for small-screen cam, ---------------------------------------------------- plutovg.mk v1.3.2 # Version: Commits on Nov 18, 2025 ---------------------------------------------------- Release v1.3.2, ------------------------------------------------------------------------------------ box64.mk 41bdb5db66e34240e702c1601731624f0eca971f # Version: Commits on Nov 18, 2025 ------------------------------------------------------------------------------------ [BOX32] Another attempt to fix build on older system, ------------------------------------------------------------------------------------ cdogs.mk ebbf7210f9714f302a1b36257d6357757427e4fc # Version: Commits on Nov 18, 2025 ------------------------------------------------------------------------------------ Bear head #712, --------------------------------------------------------------------------------------- corsixth.mk 39d721148dc1ea71e06e12131ae50a0876734fc3 # Version: Commits on Nov 17, 2025 --------------------------------------------------------------------------------------- Merge pull request #3125 from lewri/sideobject_relocate Take SideObject out of the bin, ------------------------------------------------------------------------------------------ devilutionx.mk 02a153fe26fb9a69605d8b08bfefbe9de8af87c0 # Version: Commits on Nov 18, 2025 ------------------------------------------------------------------------------------------ Update last echo time when echo requests are sent, ---------------------------------------------------------------------------------------- openmohaa.mk 4a839f5b41523f9c8149884afe216c37412dda3c # Version: Commits on Nov 17, 2025 ---------------------------------------------------------------------------------------- docs(changelog): update changelog, -------------------------------------------------------------------------------------- stalker.mk 47f01c0aeed3cba4119e29db352afa54a3e7aee0 # Version: Commits on Nov 18, 2025 -------------------------------------------------------------------------------------- build(deps): bump Externals/imgui from `3109131` to `4fa59df` (#1994) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>, ---------------------------------------------------------------------------------- stk.mk 94712c31fb6f5155243779a9551c441c7795b831 # Version: Commits on Nov 18, 2025 ---------------------------------------------------------------------------------- Add scrollbar to server lobby chat (#5566) Add a scrollbar to the chat in the server lobby that allows users to scroll through chat history. Included: mouse wheel scrolling, page up/down keyboard support, auto-scroll when at bottom, and proper scroll position preservation across window resizing., --------------------------------------------------------------------------------------- mangohud.mk 7ada82625b38bff2b63d12e15378ca5e0101d05e # Version: Commits on Nov 18, 2025 --------------------------------------------------------------------------------------- fps_metrics: don't access metrics vec directly, -------------------------------------------------------- vkd3d-proton.mk v3.0a # Version: Commits on Nov 18, 2025 -------------------------------------------------------- Tiny bugfix release that addresses a silly performance regression in the new unified image layout path., ---------------------------------------------------------------------------------------------------- sdl2-gamecontrollerdb.mk e1efb4bad8730b2c0c6316617cbd06b9def1192e # Version: Commits on Nov 18, 2025 ---------------------------------------------------------------------------------------------------- Clean up XinMoTek, Ultimate Atari Fight Stick, ---------------------------------------------------------------------------------------- retroarch.mk 1efcc55bff10b662568fcf863374bdc8571e669a # Version: Commits on Nov 18, 2025 ---------------------------------------------------------------------------------------- Android: Add HAVE_CHEEVOS_RVZ, -------------------------------------------------------------------------------------- vkquake.mk 6f9c012a9176ee36663fd7a6d30b6291a0dbbcc1 # Version: Commits on Nov 18, 2025 -------------------------------------------------------------------------------------- Fix bad parenthesis, ---------------------------------------------------------------------------------- trx.mk aac77f308486c8f345d39ec6a64a0d09fe17b94f # Version: Commits on Nov 18, 2025 ---------------------------------------------------------------------------------- objects/rolling_ball: fix interpolation when stopped As boulders are always animated after being triggered, we need to disable interpolation when they become deactivated., ------------------------------------------------------------------------------------------ xash3d-fwgs.mk 27086bfb977358d4b7c878951a23bca781dc8deb # Version: Commits on Nov 18, 2025 ------------------------------------------------------------------------------------------ engine: set r_wadtextures and r_allow_wad3_luma as latched cvars, as those require reloading textures and thus the game, ------------------------------------------------------------------------------------------------ libretro-bsnes-jg.mk f729ad4074c1955bd8bfebbb2e1a3078794804c6 # Version: Commits on Nov 17, 2025 ------------------------------------------------------------------------------------------------ Merge branch 'master' into libretro, --------------------------------------------------------------------------------------------- libretro-fbneo.mk 01e29d5020880990cff42ac43bc6f016fc048761 # Version: Commits on Nov 18, 2025 --------------------------------------------------------------------------------------------- (libretro) update files, ----------------------------------------------------------------------------------------------- libretro-flycast.mk 1dac3695fda391cfb4e03bd9f62c8018248b9365 # Version: Commits on Nov 18, 2025 ----------------------------------------------------------------------------------------------- imgui: ImguiStyleVar must be deleted before the end of the window, ------------------------------------------------------------------------------------------------- libretro-geargrafx.mk 955169f4039060c76b1262d1a30261cae2522f84 # Version: Commits on Nov 18, 2025 ------------------------------------------------------------------------------------------------- Improve BRAM saving/loading, ------------------------------------------------------------------------------------------------- libretro-picodrive.mk 046e5ff91eb4bfa728e51e01304ff73cf6b4ee96 # Version: Commits on Nov 17, 2025 ------------------------------------------------------------------------------------------------- Merge pull request #256 from BinBashBanana/master Fix emscripten, --------------------------------------------------------------------------------------------- libretro-vba-m.mk f7ef244160488e99256cf7be4b9877ff4e5da607 # Version: Commits on Nov 18, 2025 --------------------------------------------------------------------------------------------- Fix `systemScreenMessage()` for scale and Unicode Fix `systemScreenMessage()` for wxWidgets (the OSD messages) to be the same scale regardless of filter scale and to display Unicode correctly. There is enough space for 3 lines at the bottom, which should be generally sufficient. The `drawText()` function is replaced with `drawTextWx()` for the wxWidgets interface for this purpose, using wxWidgets facilities for drawing text on an image. Fixed with Claude and lots of testing. Signed-off-by: Rafael Kitover <[email protected]>, -------------------------------------------------------------------------------------------- slang-shaders.mk ddc45cfc849c0a33bf715d1669bf9fd8ca493fc0 # Version: Commits on Nov 18, 2025 -------------------------------------------------------------------------------------------- initial reorg for crt-effects subdir (#807) * initial reorg for crt-effects subdir * missed a couple of glow-trails paths,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having it set to
trueprevented the '_parent fallback' behavior in some cases where it shouldn't have (see added test), and it didn't have any other effect.Removing it also simplifies a lot of code, so this is a win/win!