Add option to fail if ignored identifiers weren't seen #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users need to opt-in to this behavior via the strict_ignore flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I frequently use
bundler-auditas a step in my CI/CD pipeline and will add an identifier to theignorelist to acknowledge that I know about the vulnerability but aren't able to upgrade the gem yet. In order to keep that list of ignored CVEs manageable, I would likebundler-auditto (optionally) fail if I've ignored an identifier but the scan did not find that identifier. This would force me to clean up the list of ignored identifiers after upgrading a gem.This change will only output a warning message when using the
textformat because I couldn't think of a non-breaking way to add it to the JSON and XML outputs. Maybe the option should be restricted to just thetextformat? It would probably be annoying to return an error code without providing an explanation about why.