Upgrade opensearch-ruby from 3.4.0 to 4.0.0.pre.beta.5#6567
Draft
larouxn wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6567 +/- ##
==========================================
- Coverage 97.14% 94.64% -2.50%
==========================================
Files 516 516
Lines 11022 11081 +59
==========================================
- Hits 10707 10488 -219
- Misses 315 593 +278 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
larouxn
force-pushed
the
opensearch_4
branch
6 times, most recently
from
ce7d1a6 to
e554c74
Compare
larouxn
force-pushed
the
opensearch_4
branch
2 times, most recently
from
9159554 to
dba6f4c
Compare
Includes manual `utc.iso8601` casting of `updated` fields as well as updating of tests expectations accordingly due to opensearch-ruby 4's change to use the stdlib `json` gem instead of `multi_json` for serialization. Issue being `JSON.parse` does not convert timestamps to ISO8601 format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 Testing a bump to opensearch-ruby 4 which is still in beta, as such would make #6566 irrelevant. 🚧