DevContainer fixes#6540
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the DevContainer developer experience by simplifying system test networking/configuration and adjusting database configuration so the containerized services work without relying on DATABASE_URL.
Changes:
- Simplifies Capybara/WebMock configuration for DevContainer-driven test runs (removes
served_by/env overrides and narrows WebMock allowlist). - Updates
config/database.yml.sampleto support a containerized DB viaDB_HOSTinstead of hardcodedlocalhost. - Updates DevContainer environment variables and updates Playwright installation in
bin/setup.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
test/test_helper.rb |
Removes DevContainer-specific host branching and tightens WebMock allowlist. |
test/application_system_test_case.rb |
Removes served_by override tied to CAPYBARA_SERVER_PORT. |
config/database.yml.sample |
Uses DB_HOST env var to point Rails at the containerized Postgres service. |
bin/setup |
Installs Playwright Chromium with --with-deps during setup. |
.devcontainer/devcontainer.json |
Drops DATABASE_URL/Capybara envs and sets DB_HOST for DB connectivity. |
.devcontainer/devcontainer-lock.json |
JSON formatting/structure normalization (no functional change). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6540 +/- ##
==========================================
- Coverage 97.09% 97.08% -0.01%
==========================================
Files 511 511
Lines 10775 10775
==========================================
- Hits 10462 10461 -1
- Misses 313 314 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes up a few issues that was causing the DevContainer experience to not be up to scratch. Notable changes are some over Capybara configuration that needed cleaning up, and some tweaks to how we set the database, and dropping
DATABASE_URL.After this PR is merged, I can run spin up a DevContainer with everything pre-configured, and all tests are now passing. 🎉