Skip to content

DevContainer fixes#6540

Merged
colby-swandale merged 4 commits into
masterfrom
colby/devcontainer-fixes
May 21, 2026
Merged

DevContainer fixes#6540
colby-swandale merged 4 commits into
masterfrom
colby/devcontainer-fixes

Conversation

@colby-swandale

Copy link
Copy Markdown
Member

This PR fixes up a few issues that was causing the DevContainer experience to not be up to scratch. Notable changes are some over Capybara configuration that needed cleaning up, and some tweaks to how we set the database, and dropping DATABASE_URL.

After this PR is merged, I can run spin up a DevContainer with everything pre-configured, and all tests are now passing. 🎉

Copilot AI review requested due to automatic review settings May 21, 2026 03:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the DevContainer developer experience by simplifying system test networking/configuration and adjusting database configuration so the containerized services work without relying on DATABASE_URL.

Changes:

  • Simplifies Capybara/WebMock configuration for DevContainer-driven test runs (removes served_by/env overrides and narrows WebMock allowlist).
  • Updates config/database.yml.sample to support a containerized DB via DB_HOST instead of hardcoded localhost.
  • Updates DevContainer environment variables and updates Playwright installation in bin/setup.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/test_helper.rb Removes DevContainer-specific host branching and tightens WebMock allowlist.
test/application_system_test_case.rb Removes served_by override tied to CAPYBARA_SERVER_PORT.
config/database.yml.sample Uses DB_HOST env var to point Rails at the containerized Postgres service.
bin/setup Installs Playwright Chromium with --with-deps during setup.
.devcontainer/devcontainer.json Drops DATABASE_URL/Capybara envs and sets DB_HOST for DB connectivity.
.devcontainer/devcontainer-lock.json JSON formatting/structure normalization (no functional change).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.08%. Comparing base (0689682) to head (5f85a79).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6540      +/-   ##
==========================================
- Coverage   97.09%   97.08%   -0.01%     
==========================================
  Files         511      511              
  Lines       10775    10775              
==========================================
- Hits        10462    10461       -1     
- Misses        313      314       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@colby-swandale colby-swandale merged commit 2fa27d3 into master May 21, 2026
19 of 20 checks passed
@colby-swandale colby-swandale deleted the colby/devcontainer-fixes branch May 21, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants