[wip] Add mastodon handles to profile #3321
Conversation
| ) | ||
| %> | ||
|
|
||
| <%= mastodon_handle(user) %> |
There was a problem hiding this comment.
Isn't it possible to generate link using mastodon handle? 🤔
There was a problem hiding this comment.
@simi I wasn't able to find a way to do this, it's also weird if we just let anyone put any link they want on the profile? We probably have to sanitize it, etc.
There was a problem hiding this comment.
Isn't enough to just split on last @ and reverse join with / (and prepending https protocol)?
|
@zzak ad mastodon handle it seems I was right according to docs. The only unknown part is the protocol (http/https), but we can make it into note we support only secured HTTPS servers. Would you like to continue on this? Alternatively just ping me and I can do my best to finish this feature. |
|
@simi Thanks for the ping, have been busy with other stuff but I may pick this back up. This also seems like a really good bite-sized feature for an early contributor, happy to hand it over in that case! |
|
See rubygems/rfcs#51 |
github-project-automation
bot
moved this from Hold
to Merged
in RubyGems.org Pull Requests
3 participants
No description provided.