Upgrade elasticsearch for Ruby 3 compatibility#3311
Closed
deivid-rodriguez wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3311 +/- ##
==========================================
- Coverage 98.52% 98.11% -0.42%
==========================================
Files 113 113
Lines 3390 3390
==========================================
- Hits 3340 3326 -14
- Misses 50 64 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Martin <martin.emde@gmail.com>
56a6175 to
9a871e5
Compare
Contributor
Author
|
It wasn't as easy, which explains why #3299 bumps all the gems it currently bumps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting the following error when running the following command from CONTRIBUTING.md docs:
Turns out this is fixed upstream by this PR by @indirect: elastic/elasticsearch-rails#992.
This PR is just a less ambitious version of #3299, just to get past this error.