Eliminate access of RubyBasicObject flags #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global object flags will become private in a future JRuby version, to allow replacing them with smaller and more localized flags in each type of object. This patch moves the StringIO-specific flags into the StringIO object and eliminates all accesses of the global RubyBasicObject.flags.
Contributor
Author
|
@kou @nobu This can be merged and released at any time. Let me know if I can proceed with that. jruby/jruby#9095 will depend upon it. |
Member
|
You can do it! |
Contributor
Author
Done! I wasn't sure how much detail to put in NEWS so I included the first line of all recent commits plus the issue numbers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global object flags will become private in a future JRuby version, to allow replacing them with smaller and more localized flags in each type of object. This patch moves the StringIO-specific flags into the StringIO object and eliminates all accesses of the global RubyBasicObject.flags.