-
Notifications
You must be signed in to change notification settings - Fork 35
Closed
Description
The commit below changed how chilled strings are handled:
This results in different behavior compared to previous versions:
StringIO.new(str = '🚀').tap { _1.set_encoding(Encoding::BINARY) }; str
# Ruby / StringIO
- StringIO 3.1.7
- Ruby 3.3.x: "\xF0\x9F\x9A\x80"
- Ruby 3.4.x: "\xF0\x9F\x9A\x80"
- StringIO 3.1.8
- Ruby 3.3.x: "\xF0\x9F\x9A\x80"
- Ruby 3.4.x: "🚀"
The discussion around the change has already taken place, so I will not reopen it here:
- Do not issue warning when calling set_encoding if string is chilled #128
- https://bugs.ruby-lang.org/issues/21280
I understand the motivation for the change, but since it was not documented in NEWS, it took a long time to figure out what was happening.
It would be very helpful if this breaking change could be added to the NEWS for 3.1.8.
Thank you! 😄
Metadata
Metadata
Assignees
Labels
No labels