Workaround for bundler examples with ruby head version.#7878
Merged
deivid-rodriguez merged 1 commit intomasterfrom Jul 19, 2024
Merged
Workaround for bundler examples with ruby head version.#7878deivid-rodriguez merged 1 commit intomasterfrom
deivid-rodriguez merged 1 commit intomasterfrom
Conversation
It's part of dependencies for Sinatra. we should fix mustermann before final release of Ruby 3.4
deivid-rodriguez
approved these changes
Jul 19, 2024
Contributor
|
Merging to get CI back to green, thanks @hsbt! |
deivid-rodriguez
added a commit
that referenced
this pull request
Jul 31, 2024
Workaround for bundler examples with ruby head version. (cherry picked from commit 7e8f1e1)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I merged ruby/uri#107 and sync
ruby/rubytoday. This change makesRFC3986_Parserby default forURImodule.After that,
bundler/spec/install/gems/dependency_api_fallback_spec.rbis broken with new default parser. Because mustermann that is part of Sinatra dependency depends on URI::RFC2396_PARSER behavior.What is your fix for the problem, implemented in this PR?
I switched
RFC2396_PARSERwhile failing example as workaround.I already submitted sinatra/mustermann#138 to fix this issue.
Make sure the following tasks are checked