Require prism >= 0.19.0

[tompng]

Remove StringNode workaround
Simplify CallNode attribute assign check (CallNode#attribute_write? is added)
Fix for added nodes NumberedParametersNode CallTargetNode IndexTargetNode ImplicitRestNode

[st0012]

If I understand it correctly, after this change we'll be supporting both Prism 0.18 and 0.19? If that's the case, maybe we should just move towards 0.19 as people should always upgrade Prism, especially before Ruby 3.3?
In the meantime, we can point Prism to GH source in the Gemfile.

[tompng]

I was thinking of:

1. Support both(prism head and 0.18.0) for now
2. Switch to 0.19.0, remove code for 0.18.0
3. Release repl_type_completor

Mainly to make CI green. (but it makes code complicated...)

Using github source in Gemfile seems good, I'll try it.

[st0012]

There's a if node.rest condition a few lines above, which seems to already expect it to be Prism::RestParameterNode? Perhaps we can merge that and this together?

[tompng]

I removed the confusing comment in the if node.rest condition and add a comment about Prism::ImplicitRestNode that does not have name.

The if node.rest above part is separating given args to reqs, posts, rest
method do |a,b=1,*c| and given args [Integer, String, Symbol] to reqs = [Integer], opts = [String], posts = [], rest = [Symbol].

This part is assigning each of them.

node.requireds.zip{assign}
node.optionals.zip{assign}
node.posts.zip{assign}
if node.rest; assign; end

I want to separate them, not to merge it together.

[st0012]

I see, thanks for the clear explanation 👍