Remove useless condition check #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since threads count is already guaranteed to be less or equal than max_active_threads in thread_pool.rb:line 113, there is no need to double check. Not to mention that this will cause a race condition on the JRuby platform, as noted in 5ac9df0. Removing the conditional check will also reduce lock acquisitions and improve overall efficiency. In the original commit 1737459, this check was essential. However, after subsequent changes, it seems no one performed a careful review of this logic.
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since threads count is already guaranteed to be less or equal than max_active_threads in thread_pool.rb:line 113, there is no need to double check.
Not to mention that this will cause a race condition on the JRuby platform, as noted in 5ac9df0.
Removing the conditional check will also reduce lock acquisitions and improve overall efficiency.
In the original commit 1737459, this check was essential. However, after subsequent changes, it seems no one performed a careful review of this logic.