Skip to content

Suppress "literal string will be frozen in the future" warning #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 2 commits into from
Oct 18, 2024
Merged

Suppress "literal string will be frozen in the future" warning #1019

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
020c67c
Suppress "literal string will be frozen in the future" warning
tikkss Oct 13, 2024
37fe153
Making build_statement not modify the given argument
tikkss Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/irb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,7 @@ def build_statement(code)
return Statement::EmptyInput.new
end

code.force_encoding(@context.io.encoding)
code.dup.force_encoding(@context.io.encoding)
Copy link
Copy Markdown
Member

@tompng tompng Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement has no effect. We need to change the encoding of code.
maybe code = code.dup.force_encoding(@context.io.encoding)

Copy link
Copy Markdown
Contributor Author

@tikkss tikkss Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review and suggestion! I fixed them at
37fe153.

By the way, I met the warning in SciRuby/iruby's test code, SciRuby/iruby's code.

if (command, arg = @context.parse_command(code))
command_class = Command.load_command(command)
Statement::Command.new(code, command_class, arg)
Expand Down