Add job for CI using Prism parser #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
Mar 21, 2024
pirj
reviewed
Mar 21, 2024
ydah
force-pushed
the
support_prism
branch
3 times, most recently
from
1075b45 to
1719fc6
Compare
ydah
changed the title
pirj
approved these changes
Mar 21, 2024
Member
pirj
left a comment
pirj
left a comment
There was a problem hiding this comment.
Thanks!
I’d feel a tad more confident if we ran rake default, not just the spec task
Member
Author
OK. I updated this PR. |
Member
Author
|
If there is a problem, we can delete this job so I merge this PR. |
bquorning
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Oct 17, 2024
Copied from rubocop/rubocop-capybara#112 Co-authored-by: ydah <[email protected]>
6 tasks
bquorning
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Oct 17, 2024
Copied from rubocop/rubocop-capybara#112 Co-authored-by: ydah <[email protected]>
bquorning
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Oct 29, 2024
Copied from rubocop/rubocop-capybara#112 Co-authored-by: ydah <[email protected]>
bquorning
added a commit
to rubocop/rubocop-rspec
that referenced
this pull request
Oct 29, 2024
Copied from rubocop/rubocop-capybara#112 Co-authored-by: ydah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop-ast#277
Before submitting the PR make sure the following are checked:
main(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).