feat(Message): create Message#getCommand method
#1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenlagus
reviewed
Jul 23, 2025
| public String getCommand() { | ||
| return Stream.ofNullable(entities) | ||
| .flatMap(Collection::stream) | ||
| .filter(entity -> entity != null && NumberUtils.INTEGER_ZERO.equals(entity.getOffset())) |
Owner
There was a problem hiding this comment.
Don't think we need a whole new import to check a number vs 0
Author
There was a problem hiding this comment.
There's nothing wrong with importing constants. It's a bad practice to use magic numbers.
rubenlagus
force-pushed
the
dev
branch
3 times, most recently
from
52a184e to
9203912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message#isCommandfelt lonely, so I addedMessage#getCommandfor company