Skip to content

Conversation

@rtidgreenberg
Copy link
Collaborator

  • reorganized folder structure to better align towards examples vs deployment
  • added remote administration app to enable/disable sessions and align groups
  • added new examples using remote admin app
  • Updated all readme's

@angelrti
Copy link
Member

Please, remove the build directory as this is automatically generated

@franporcel
Copy link
Collaborator

@rtidgreenberg looks good to me!

@@ -0,0 +1,28 @@
# CMake Modules for RemoteAdmin

This directory contains CMake modules copied from the RTI Connext DDS CMake Utilities repository for convenience. These modules are included locally to avoid requiring users to initialize git submodules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should keep it in a git submodule for maintainability reasons. We can add a note to the top-level readme that shows how to clone/initialize submodules properly. See an example here (section 'Installation'): https://github.com/rticommunity/rticonnextdds-gateway/tree/master

Also, in that example, we have the submodules aggregated in a top-level folder called third-party, so, they are available through the whole repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants