Skip to content

Bugfix for error found in tests #3870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 4 commits into from
Jun 16, 2025
Merged

Bugfix for error found in tests #3870

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc49cf6
Bugfix for error found when calling shiny::shinyAppTemplate without l…
stuvet Aug 9, 2023
bb824f6
Update news
cpsievert Jun 16, 2025
04dcdac
Merge branch 'main' into shinytest2-patch-1
cpsievert Jun 16, 2025
c5042bb
Update NEWS.md
cpsievert Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ In addition, various properties of the spinners and pulse can be customized with

* Fixed #3833: When `width` is provided to `textAreaInput()`, we now correctly set the width of the `<textarea>` element. (#3838)

* Fixes #3840: `updateSliderInput()` now warns when attempting to set invalid `min`, `max`, or `value` values. Sending an invalid update message to an input no longer causes other update messages to fail. (#3843)

* `shiny::shinyAppTemplate()` no longer errors without a call to `library(shiny)`. (#3870)

# shiny 1.7.4.1

Expand Down
2 changes: 1 addition & 1 deletion inst/app_template/tests/testthat/test-shinytest2.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ test_that("Initial snapshot values are consistent", {
app$expect_values()
}){{
if (isTRUE(module)) {
HTML('
shiny::HTML('


test_that("Module values are consistent", {
Expand Down