Merged
Conversation
helps to know how it will be formatted exactly
not necessary if we are switching to using lists and not data.frames
…to then extract information
Fixes #322 Fixes #323 See swagger-api/swagger-js#268 Thank you @Hong-Revo for a recursive blueprint in #323
Codecov Report
@@ Coverage Diff @@
## swagger_3 #364 +/- ##
=============================================
- Coverage 87.88% 87.84% -0.05%
=============================================
Files 27 27
Lines 1189 1193 +4
=============================================
+ Hits 1045 1048 +3
- Misses 144 145 +1
Continue to review full report at Codecov.
|
4 tasks
jcheng5
approved these changes
Jan 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrade how swagger params are handled.
Added check with swagger-cli to validate openapi v3 spec on mac / non cran computers only that have the swagger-cli pkg installed.