Skip to content

Require httpuv (>= 1.4.5.9000)#357

Merged
schloerke merged 5 commits intomasterfrom
httpuv_ver
Jan 11, 2019
Merged

Require httpuv (>= 1.4.5.9000)#357
schloerke merged 5 commits intomasterfrom
httpuv_ver

Conversation

@schloerke
Copy link
Copy Markdown
Collaborator

@schloerke schloerke commented Dec 7, 2018 •
edited
Loading

Fixes #289

  • httpuv releases to CRAN (moving to a remote in DESCRIPTION)
  • make httpuv version a >=

@schloerke schloerke added this to the future - v0.5.0 milestone Dec 7, 2018
@schloerke
Copy link
Copy Markdown
Collaborator Author

schloerke commented Dec 7, 2018

Fails due to httpuv > 1.4.5 not existing

@wch
Copy link
Copy Markdown
Collaborator

wch commented Dec 10, 2018 •
edited
Loading

For the time being, you can add a Remotes field to the DESCRIPTION file:

Remotes:
    rstudio/httpuv

I'd suggest also bumping the version requirement to httpuv (>= 1.4.5.9000).

@schloerke
Merge branch 'master' into httpuv_ver
6e1c40f 
* master:
  appveyor pkg cache will bust when DESCRIPTION changes (#370)
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@28f46ca). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #357   +/-   ##
=========================================
  Coverage          ?   87.78%           
=========================================
  Files             ?       27           
  Lines             ?     1195           
  Branches          ?        0           
=========================================
  Hits              ?     1049           
  Misses            ?      146           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f46ca...6e1c40f. Read the comment docs.

@schloerke schloerke changed the title Require httpuv (> 1.4.5) Require httpuv (>= 1.4.5.9000) Jan 11, 2019
@schloerke schloerke merged commit 5fcf2dc into master Jan 11, 2019
@schloerke schloerke deleted the httpuv_ver branch January 11, 2019 15:44
schloerke added a commit that referenced this pull request Feb 1, 2019
@schloerke
Merge branch 'master' into serializer_args
53da733 
* master:
  need to set the LC_TIME to C to ensure the Date is formatted in English (#319)
  Require httpuv (>= 1.4.5.9000) (#357)
  appveyor pkg cache will bust when DESCRIPTION changes (#370)
  Revamp Swagger Spec to OpenAPI v3 (#365)
schloerke added a commit that referenced this pull request Feb 7, 2019
@schloerke
Merge branch 'master' into httpuv_url_decode
73715c8 
* master:
  use rtools within appveyor (#381)
  need to set the LC_TIME to C to ensure the Date is formatted in English (#319)
  Require httpuv (>= 1.4.5.9000) (#357)
  appveyor pkg cache will bust when DESCRIPTION changes (#370)
  Revamp Swagger Spec to OpenAPI v3 (#365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@schloerke @wch @codecov-io