Skip to content

Conversation

@lbm364dl
Copy link
Contributor

@lbm364dl lbm364dl commented Aug 25, 2025

Closes #788.

Allowing multiple types in pin_write required some minor tweaks in pin_read. Instead of just choosing an arbitrary type from those available to read from, I also added a type argument in pin_read.

@lbm364dl lbm364dl force-pushed the accept-multiple-formats-pins-write branch from 9679f5c to b8717d1 Compare August 25, 2025 20:19
@juliasilge
Copy link
Member

Was there more you wanted to do here before a review, @lbm364dl? I notice it is still draft.

@lbm364dl
Copy link
Contributor Author

Was there more you wanted to do here before a review, @lbm364dl? I notice it is still draft.

Yes, my intention was to address this thing I mentioned in the linked issue:

If I have larger files, ideally I wouldn't want users to download a CSV they're not even going to use, because they would just use the other compressed/fast format

I didn't have time to look into that. But it should be independent anyway. I can try in another PR. What is present here should already be enough to close the issue.

A review is more than welcome.

@lbm364dl lbm364dl marked this pull request as ready for review August 29, 2025 19:35
Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of wonder if we should just error and refuse to read if people try to read without type for a pin with multiple types, but we can try this out and see how people experience it.

Thanks for this contribution, @lbm364dl!

pin_write(board, mtcars, name = "mtcars", type = "froopy-loops")
Condition
Error in `object_write()`:
Error:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get the call to work correctly in this case for the error, so we'll just go with this for now.

@juliasilge juliasilge merged commit 6966087 into rstudio:main Sep 3, 2025
14 checks passed
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: option to deploy human-readable format in parallel with binary deployment for datasets

2 participants