Add odt_document2 and powerpoint_presentation2#742
Conversation
|
May be it's better to factor out duplicated codes into a new function ( |
|
Yes, that is exactly what I was thinking. Please do factor out the code instead of repeating it in three functions. Thank you! |
|
Done it by implementing As rewriting extremely simplfied |
|
I confirmed |
yihui
left a comment
There was a problem hiding this comment.
Perfect. Thank you so much!
@atusy, Cross-references are broken in the rendered results. Would you mind testing it with the following?: |
|
As far as I tried, broken cross-references occur only at Table \<span class="redoc" id="redoc-citation-1"><span class="redoc" id="redoc-citation-2"><span class="redoc" id="redoc-citation-3">@ref</span></span></span>(tab:iris)I think this is the reason and is caused by Besides, BTW, I recommend opening issue when you see strange behavior instead of making comments on closed PR. |
|
This is most likely caused by the redoc package as I haven't yet done the work to make sure its post-processing is compatible with these formats. Feel free to open an issue over there. |
This PR adds
odt_document2andpowerpoint_presentation2and closes #722 #741Though I'm not sure
powerpoint_presentation2is a scope of bookdown, bookdown is the only place to implement it.odt
I rendered
inst/examples/index.Rmd.The result seems to be fine.
bookdown.zip
Exceptionally, when math expressions appeear right after the code blocks, the math expressions appear within code blocks.
However, this is not a problem of bookdown because the same problem occurs in
rmarkdown::odt_document.pptx
Cross reference seems to be working fine