Skip to content

fix: error on generating description from a long sentence #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cderv merged 3 commits into from
Apr 3, 2024
+3 −3
Merged

fix: error on generating description from a long sentence #1463

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9904ac0
fix: error in 1:max_n from bs4_book()
atusy Apr 3, 2024
c52b6c4
doc(NEWS): fixed error on generating description from a long sentence
atusy Apr 3, 2024
87f8f61
Bump dev version
cderv Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# CHANGES IN bookdown VERSION 0.39


- Fixed a bug that `bs4_book()` errors on generating document description. The error occured when the beggining of the document is a very long sentence without spaces (> 197 characters), which typically happens in CJK languages (thanks, @atusy, #1463).

# CHANGES IN bookdown VERSION 0.38

Expand Down
2 changes: 1 addition & 1 deletion R/bs4_book.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ tweak_metadata <- function(html, path) {
if (nzchar(text)) {
words <- unlist(strsplit(text, " "))
no_char <- cumsum(unlist(lapply(words, function(x) {nchar(x) + 1})))
max_n <- max(which(no_char<= 197))
max_n <- max(which(no_char <= 197), 1)
description_string <- paste(words[1: max_n], collapse = " ")
if (max_n != length(words)) {
description_string <- paste0(description_string, "...")
Expand Down