Skip to content

Add tests for LinRegR2 and LinRegVariance with NULL arguments #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsim merged 3 commits into from
Feb 20, 2026
Merged

Add tests for LinRegR2 and LinRegVariance with NULL arguments #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff3b225
Add tests for LinRegR2 and LinRegVariance with NULL arguments
jjustaments Feb 11, 2026
e645f21
Update Mondrian with LinReg fix
rsim Feb 20, 2026
b80a8c3
Use should be_nan syntax in tests
rsim Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified lib/mondrian/jars/mondrian-9.3.0.0.jar
View file
Open in desktop
Binary file not shown.
30 changes: 30 additions & 0 deletions spec/mondrian_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,21 @@ def nonempty_crossjoin_from_cube(cube_name)
columns('[Measures].[LinRegR2]').execute
result.values.should == [1.0]
end

it "should return NaN when value cannot be calculated due to NULL arguments" do
result = @olap.from('Sales').
with_member('[Measures].[LinRegR2]').as(
<<~MDX
LinRegR2(
[Customers].[Country].Members,
NULL,
Rank([Customers].CurrentMember, [Customers].[Country].Members)
)
MDX
).
columns('[Measures].[LinRegR2]').execute
result.values.first.should be_nan
end
end

describe "LinRegVariance" do
Expand Down Expand Up @@ -753,6 +768,21 @@ def nonempty_crossjoin_from_cube(cube_name)
columns('[Measures].[LinRegVariance]').execute
result.values.should == [0.0]
end

it "should return NaN when value cannot be calculated due to NULL arguments" do
result = @olap.from('Sales').
with_member('[Measures].[LinRegVariance]').as(
<<~MDX
LinRegVariance(
[Customers].[All Customers],
NULL,
Rank([Customers].CurrentMember, [Customers].[Country].Members)
)
MDX
).
columns('[Measures].[LinRegVariance]').execute
result.values.first.should be_nan
end
end

describe "Instr with function returning NULL" do
Expand Down